Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][IMP] shipment_advice: Autovalidate #128

Closed

Conversation

vnikolayev1
Copy link

  • modified shipment_advice, so whenever we set stock move to done, and if autovalidate shipment advice is enabled in company settings - we set shipment advice to done
  • updated tests, covered backorder.

@vnikolayev1
Copy link
Author

Sorry guys, messed up with rebase on #126
@mt-software-de

@vnikolayev1 vnikolayev1 force-pushed the 14.0-shipment_advice_auto_validate branch from 11fdb13 to ca02118 Compare June 21, 2024 14:09
@rousseldenis rousseldenis added this to the 14.0 milestone Jun 22, 2024
@mt-software-de
Copy link
Contributor

This PR depends on #123

@@ -12,6 +12,7 @@ class StockMove(models.Model):
ondelete="set null",
string="Planned shipment",
index=True,
copy=False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to reverted when #123 is merged.

shipment_advice/tests/test_shipment_advice.py Show resolved Hide resolved
@mt-software-de
Copy link
Contributor

Could you please change the PR title to "[14.0][IMP] shipment_advice: Autovalidate"
Could you please also change your commit message, to something like
"
[IMP] shipment_advice: Autovalidate on move's action_done
some description
"

@vnikolayev1 vnikolayev1 changed the title [ADD][IMP] shipment_advice [14.0][IMP] shipment_advice: Autovalidate Jul 2, 2024
@vnikolayev1 vnikolayev1 force-pushed the 14.0-shipment_advice_auto_validate branch from ca02118 to dbe36fd Compare July 2, 2024 19:21
- modified shipment_advice, so whenever we set stock move to done, and if autovalidate shipment advice is enabled in company settings - we set shipment advice to done
- updated tests.
@vnikolayev1 vnikolayev1 force-pushed the 14.0-shipment_advice_auto_validate branch from dbe36fd to e03b20e Compare July 2, 2024 19:24
Copy link

@henrybackman henrybackman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Technical review)

@jbaudoux jbaudoux closed this Jul 11, 2024
@vnikolayev1 vnikolayev1 deleted the 14.0-shipment_advice_auto_validate branch July 29, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants